hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r528648823
##########
File path: libminifi/test/TestBase.cpp
##########
@@ -61,78 +62,51 @@ TestPlan::~TestPlan() {
for (auto& processor : configured_processors_) {
processor->setScheduledState(core::ScheduledState::STOPPED);
}
+ for (auto& connection : relationships_) {
Review comment:
There was an issue where we could not get processors to stop due to them
being cross-referenced by their corresponding connections, holding
cross-ownerships. This prevented them to be properly freed in the testcases
using `TestBase`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
