fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535196611
########## File path: libminifi/src/utils/tls/WindowsCertStoreLocation.cpp ########## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifdef WIN32 + +#include "utils/tls/WindowsCertStoreLocation.h" + +#include <wincrypt.h> + +#include <array> +#include <utility> + +#pragma comment(lib, "crypt32.lib") +#pragma comment(lib, "Ws2_32.lib") + +namespace { + +constexpr std::array<std::pair<const char*, DWORD>, 8> SYSTEM_STORE_LOCATIONS{{ Review comment: There is a reason, but not a very good one. :) Originally both were `std::pair`; I prefer that as it means less code, and it is more similar to `std::map`. But the constructor of `std::pair` is not constexpr before C++14, and AppleClang is strict about that, so I had to change `std::pair` to a custom struct in code which is compiled on MacOS. `WindowsCertStoreLocation` is only compiled on Windows, which is on C++14 already, so I could use `std::pair` here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
