fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535466913
##########
File path: libminifi/src/controllers/SSLContextService.cpp
##########
@@ -269,10 +505,8 @@ void SSLContextService::onEnable() {
}
passphrase_file.close();
}
- // load CA certificates
- if (!getProperty(caCert.getName(), ca_certificate_)) {
- logger_->log_error("Can not load CA certificate.");
Review comment:
It isn't an error any longer, because now there is a valid use case when
the server certificate name is blank and
`nifi.security.use.system.cert.store=true`. In that case, we will try to find
the server certificate in the system store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
