adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535295187
########## File path: libminifi/include/utils/tls/CertificateUtils.h ########## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once +#ifdef OPENSSL_SUPPORT + +#include <openssl/ssl.h> + +#ifdef WIN32 +#include <windows.h> +#include <wincrypt.h> +#endif // WIN32 + +#include <memory> + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace utils { +namespace tls { + +struct EVP_PKEY_deleter { + void operator()(EVP_PKEY* pkey) const { EVP_PKEY_free(pkey); } +}; +using EVP_PKEY_unique_ptr = std::unique_ptr<EVP_PKEY, EVP_PKEY_deleter>; + +struct X509_deleter { + void operator()(X509* cert) const { X509_free(cert); } +}; +using X509_unique_ptr = std::unique_ptr<X509, X509_deleter>; + +#ifdef WIN32 +// Returns nullptr on errors +X509_unique_ptr convertWindowsCertificate(const PCCERT_CONTEXT certificate); + +// Returns nullptr if the certificate has no associated private key, or the private key could not be extracted +EVP_PKEY_unique_ptr extractPrivateKey(const PCCERT_CONTEXT certificate); Review comment: top-level `const` has no effect here, a parameter passed by value being `const` is an implementation detail IMO and should be only in the definition https://abseil.io/tips/109 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
