adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551902469
##########
File path: libminifi/test/unit/ZlibStreamTests.cpp
##########
@@ -97,7 +106,8 @@ TEST_CASE("gzip compression and decompression pipeline",
"[basic]") {
for (size_t i = 0U; i < 1024U; i++) {
std::generate(buf.begin(), buf.end(), [&](){return dist(gen);});
original += std::string(reinterpret_cast<const char*>(buf.data()),
buf.size());
- REQUIRE(buf.size() == compressStream.write(buf.data(), buf.size()));
+ int buffer_size = gsl::narrow<int>(buf.size());
+ REQUIRE(buffer_size == compressStream.write(buf.data(),
gsl::narrow<int>(buffer_size)));
Review comment:
the `gsl::narrow` at line `110` is not necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
