adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551902820
##########
File path: main/AgentDocs.cpp
##########
@@ -47,7 +47,7 @@ std::string AgentDocs::extractClassName(const std::string
&processor) const {
auto lastOfIdx = processor.find_last_of(".");
if (lastOfIdx != std::string::npos) {
lastOfIdx++; // if a value is found, increment to move beyond the .
- int nameLength = processor.length() - lastOfIdx;
+ size_t nameLength = processor.length() - lastOfIdx;
std::string processorName = processor.substr(lastOfIdx, nameLength);
Review comment:
similarly to the ones you replaced, the `nameLength` is likewise
unnecessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
