fgerlits commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551967884
##########
File path: libminifi/src/provenance/Provenance.cpp
##########
@@ -178,8 +181,8 @@ bool
ProvenanceEventRecord::Serialize(org::apache::nifi::minifi::io::BufferStrea
if (this->_eventType == ProvenanceEventRecord::FORK || this->_eventType ==
ProvenanceEventRecord::CLONE || this->_eventType ==
ProvenanceEventRecord::JOIN) {
// write UUIDs
- uint32_t number = this->_parentUuids.size();
- ret = outStream.write(number);
+ uint32_t parent_uuids_size =
gsl::narrow<uint32_t>(this->_parentUuids.size());
Review comment:
yes, I think it's slightly better -- changed it to `..._count`
##########
File path: libminifi/src/provenance/Provenance.cpp
##########
@@ -189,8 +192,8 @@ bool
ProvenanceEventRecord::Serialize(org::apache::nifi::minifi::io::BufferStrea
return false;
}
}
- number = this->_childrenUuids.size();
- ret = outStream.write(number);
+ uint32_t chldren_uuids_size =
gsl::narrow<uint32_t>(this->_childrenUuids.size());
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
