arkadius commented on pull request #4773: URL: https://github.com/apache/nifi/pull/4773#issuecomment-787473961
> Thanks for the contribution @arkadius. Moving in the direction of `DateTimeFormatter` is a good thing, and it sounds like the performance improvements are also notable. There are some particular nuances when it comes to time zone handling, so it is important to have a good number of unit tests to ensure expected behavior regardless of the system default time zone. > > I noted several concerns and questions that would be helpful to address. Both @adenes and @turcsanyip have recent experience dealing date parsing issues, so it would be helpful to get additional feedback. Thanks for review @exceptionfactory . I hope that I've fixed most places that you've pointed out. Regards to time zone I was trying to make as few changes in current expressions logic as it is possible and nifi expression language currently uses system time zone in some cases. By my comment "some slight differences in interpreting time zone format" I meant that e.g. if someone used `X` format, he/she may need to change it to `XXX` for input text like `+01:00` - it is because of changes of handling formats between `SimpleDateTime` and `DateTimeFormatterBuilder`. Using `.parseLenient().parseCaseInsensitive()` minimize number of those differences but not to zero. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
