arkadius commented on pull request #4773:
URL: https://github.com/apache/nifi/pull/4773#issuecomment-811352295


   And what about other concers that I was pointing out? We will also add
   `formatDateTime` next to `format`? Also `toDateTime` produces the same type
   (`Date`). I haven't changed it because it would be a bigger change to
   prepare good interoperability with new java time api in other places.
   
   śr., 31 mar 2021, 20:50 użytkownik Joey ***@***.***> napisał:
   
   > Even if this was a change made in 2.0, it could still result in a silent
   > change. Being realistic about people reading migration notes, I think it's
   > very likely whatever bad things would happen today would also happen in 2.0
   > whether it was documented or introduced with a feature flag.
   >
   > That makes me not actually hate the addition of toDateTime() since it
   > describes what it really is, and the migration path could be to remove
   > toDate() in 2.0 so things break instead of silently affecting the
   > correctness of the data. How would we get people to move to it in the
   > interim? Or even just not create confusion about which to pick. There's not
   > much payoff today if they don't switch. Log message?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/nifi/pull/4773#issuecomment-811340385>, or
   > unsubscribe
   > 
<https://github.com/notifications/unsubscribe-auth/AAECOROWKTRYPFKOVJC46RTTGNVIPANCNFSM4WMUMUPQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to