szaszm commented on a change in pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r592295410
##########
File path:
extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
##########
@@ -563,7 +563,7 @@ bool
SourceInitiatedSubscriptionListener::Handler::handleSubscriptionManager(str
ws_xml_add_child(subscribe_node, XML_NS_EVENTING, WSEVENT_EXPIRES,
millisecondsToXsdDuration(processor_.subscription_expiration_interval_).c_str());
// Body/Filter
- WsXmlNodeH filter_node = ws_xml_add_child(subscribe_node, XML_NS_WS_MAN,
WSM_FILTER, processor_.xpath_xml_query_.c_str());
+ // WsXmlNodeH filter_node = ws_xml_add_child(subscribe_node,
XML_NS_WS_MAN, WSM_FILTER, processor_.xpath_xml_query_.c_str());
Review comment:
I believe this might be an accidental behavior change.
`ws_xml_add_child` has side effects, it adds a child to the parameter node
`subscribe_node`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
