lordgamez commented on a change in pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585534552
##########
File path: nanofi/include/sitetosite/CRawSocketProtocol.h
##########
@@ -76,23 +76,15 @@ int16_t sendPacket(struct CRawSiteToSiteClient * client,
const char * transactio
CTransaction* createTransaction(struct CRawSiteToSiteClient * client,
TransferDirection direction);
-static const char * getResourceName() {
+static inline const char * getResourceName() {
Review comment:
According to @arpadboda the static function definitions in the headers
were introduced to bypass link issues, not an actual solution to the problem.
They cause `-Wunused-function` as they should be referenced in every single
translation unit where they are included. The original link issues should be
resolved in the future, but as this codebase is abandoned at the moment, the
easiest solution was to mark the static functions inline, which bypasses the
warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
