lordgamez commented on a change in pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585620832
##########
File path: libminifi/src/utils/StringUtils.cpp
##########
@@ -305,8 +305,10 @@ bool StringUtils::from_base64(uint8_t* data, size_t*
data_length, const char* ba
case 1:
return false;
case 2:
- digits[2] = 0x00;
case 3: {
+ if (digit_counter == 2) {
Review comment:
After further checking the issue clang does not include the
implicit-fallthrough warning in Wall and Wextra flags, so it is only GCC
specific issue. To be backward compatible with older GCC versions I used `//
fall through` marker comment. Updated in
9b337b70b01441aea445a5d31a75c88c7ab6f680.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
