szaszm commented on a change in pull request #1029:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1029#discussion_r594992636
##########
File path: run_flake8.sh
##########
@@ -0,0 +1,6 @@
+#!/bin/bash
+
+set -euo pipefail
+
+directory=${1:-.}
+flake8 --exclude thirdparty,build --ignore E501,W504
--per-file-ignores="steps.py:F811" "${directory}"
Review comment:
Between W503 and W504, I would go for the other one based on this:
https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator
> In Python code, it is permissible to break before or after a binary
operator, as long as the convention is consistent locally. For new code Knuth's
style is suggested.
Knuth's style is break before the operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
