lordgamez commented on a change in pull request #1029:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1029#discussion_r596241246
##########
File path: docker/test/integration/minifi/processors/DeleteS3Object.py
##########
@@ -1,13 +1,16 @@
from ..core.Processor import Processor
+
class DeleteS3Object(Processor):
- def __init__(self,
- proxy_host = '',
- proxy_port = '',
- proxy_username = '',
- proxy_password = ''):
- super(DeleteS3Object, self).__init__('DeleteS3Object',
- properties = {
+ def __init__(
+ self,
Review comment:
Having one level of indentation here would have the same level
indentation as the following block, which is forbidden by
[E125](https://www.flake8rules.com/rules/E125.html). The recommendation is to
have another level indentation here.
##########
File path: docker/test/integration/minifi/processors/DeleteS3Object.py
##########
@@ -1,13 +1,16 @@
from ..core.Processor import Processor
+
class DeleteS3Object(Processor):
- def __init__(self,
- proxy_host = '',
- proxy_port = '',
- proxy_username = '',
- proxy_password = ''):
- super(DeleteS3Object, self).__init__('DeleteS3Object',
- properties = {
+ def __init__(
+ self,
Review comment:
Having one level of indentation here would have the same level of
indentation as the following block, which is forbidden by
[E125](https://www.flake8rules.com/rules/E125.html). The recommendation is to
have another level indentation here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
