lordgamez commented on a change in pull request #1029:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1029#discussion_r595004676
##########
File path: run_flake8.sh
##########
@@ -0,0 +1,6 @@
+#!/bin/bash
+
+set -euo pipefail
+
+directory=${1:-.}
+flake8 --exclude thirdparty,build --ignore E501,W504
--per-file-ignores="steps.py:F811" "${directory}"
Review comment:
Yes, in hindsight it makes more sense to go with that, even the [flake8
rule](https://www.flake8rules.com/rules/W503.html) mentions that this goes
against the pep8 recommendation. I added the change in
f417b932e4f76b74351c78739eefd1d462dac4b4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
