adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620907627
##########
File path: extensions/script/ExecuteScript.h
##########
@@ -36,7 +36,7 @@ namespace processors {
class ExecuteScript : public core::Processor {
public:
- explicit ExecuteScript(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit ExecuteScript(const std::string &name, const utils::Identifier&
uuid = {})
Review comment:
here as well
##########
File path: extensions/script/python/ExecutePythonProcessor.h
##########
@@ -45,7 +45,7 @@ namespace processors {
class ExecutePythonProcessor : public core::Processor {
public:
- explicit ExecutePythonProcessor(const std::string &name, utils::Identifier
uuid = utils::Identifier())
+ explicit ExecutePythonProcessor(const std::string &name, const
utils::Identifier& uuid = {})
Review comment:
here as well
##########
File path: extensions/script/python/PythonCreator.h
##########
@@ -43,7 +43,7 @@ namespace python {
class PythonCreator : public minifi::core::CoreComponent {
public:
- explicit PythonCreator(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit PythonCreator(const std::string &name, const utils::Identifier&
uuid = {})
Review comment:
here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
