adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620943362
##########
File path: libminifi/include/core/Core.h
##########
@@ -148,7 +148,7 @@ class CoreComponent {
* Constructor that sets the name and uuid.
*/
- explicit CoreComponent(const std::string &name, const utils::Identifier&
uuid = {}, const std::shared_ptr<utils::IdGenerator>& idGenerator =
utils::IdGenerator::getIdGenerator())
+ explicit CoreComponent(const std::string &name, const utils::Identifier
&uuid = {}, const std::shared_ptr<utils::IdGenerator>& idGenerator =
utils::IdGenerator::getIdGenerator())
Review comment:
one more here
##########
File path: libminifi/include/RemoteProcessorGroupPort.h
##########
@@ -81,7 +81,7 @@ class RemoteProcessorGroupPort : public core::Processor {
/*!
* Create a new processor
*/
- RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory>
&stream_factory, std::string name, std::string url, const
std::shared_ptr<Configure> &configure, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory>
&stream_factory, const std::string& name, std::string url, const
std::shared_ptr<Configure> &configure, const utils::Identifier& uuid = {}) //
NOLINT
Review comment:
one more inconsistency here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
