adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620906869



##########
File path: extensions/jni/JVMCreator.h
##########
@@ -40,7 +40,7 @@ namespace jni {
 class JVMCreator : public minifi::core::CoreComponent {
  public:
 
-  explicit JVMCreator(const std::string &name, utils::Identifier uuid = 
utils::Identifier())
+  explicit JVMCreator(const std::string &name, const utils::Identifier& uuid = 
{})

Review comment:
       inconsistent `&` placing in a few places (counted 23)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to