adamdebreceni commented on a change in pull request #1044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r630083876
##########
File path: libminifi/include/utils/gsl.h
##########
@@ -26,6 +28,26 @@ namespace minifi {
namespace gsl = ::gsl_lite;
+namespace utils {
+namespace detail {
+template<typename T>
+using remove_cvref_t = typename std::remove_cv<typename
std::remove_reference<T>::type>::type;
Review comment:
`gsl_lite` already has a `remove_cvref`, I do favor this version, we
could change the `gsl_lite` one in `optional_from_ptr` to this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
