adamdebreceni commented on a change in pull request #1044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r630087818
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -241,6 +241,18 @@ void ProcessSession::write(const
std::shared_ptr<core::FlowFile> &flow, OutputSt
}
}
+void ProcessSession::writeBuffer(const std::shared_ptr<core::FlowFile>&
flow_file, gsl::span<const char> buffer) {
+ struct BufferOutputStreamCallback : OutputStreamCallback {
Review comment:
I'd rather we move out this `SpanOutputStreamCallback`, create a
forwarding `ProcessSession::write` that takes a reference so we don't have to
create local callback variables, and call that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
