szaszm commented on a change in pull request #1083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r649300857
##########
File path: extensions/windows-event-log/CollectorInitiatedSubscription.cpp
##########
@@ -628,17 +628,16 @@ void CollectorInitiatedSubscription::unsubscribe() {
int CollectorInitiatedSubscription::processQueue(const
std::shared_ptr<core::ProcessSession> &session) {
struct WriteCallback: public OutputStreamCallback {
- WriteCallback(const std::string& str)
- : str_(str) {
- status_ = 0;
+ WriteCallback(std::string& str)
Review comment:
Previously it was copied to a member, now we store a reference (not
nullable pointer) instead. Probably I didn't realize at the time that write now
only needs a const reference to the source buffer, so I can change it to take a
const ref again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
