exceptionfactory commented on a change in pull request #5145: URL: https://github.com/apache/nifi/pull/5145#discussion_r649605589
########## File path: nifi-versioned-components/pom.xml ########## @@ -0,0 +1,52 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi</artifactId> + <version>1.14.0-SNAPSHOT</version> + </parent> + + <artifactId>nifi-versioned-components</artifactId> + + <profiles> + <profile> + <id>nifi-versioned-components_jigsaw</id> + <activation> + <jdk>(1.8,)</jdk> + </activation> + <dependencies> + <dependency> + <groupId>javax.xml.bind</groupId> + <artifactId>jaxb-api</artifactId> + </dependency> + </dependencies> + </profile> + </profiles> + + <!-- This module should kept to having no dependencies --> + <dependencies> + <dependency> + <groupId>io.swagger</groupId> + <artifactId>swagger-annotations</artifactId> + <version>1.5.16</version> + <scope>provided</scope> Review comment: Is there a specific reason this is marked as a `provided` dependency? This places a burden on referencing modules to include the dependency explicitly as a runtime dependency when needed. ########## File path: nifi-api/pom.xml ########## @@ -22,5 +22,13 @@ </parent> <artifactId>nifi-api</artifactId> <packaging>jar</packaging> - <!-- This module should kept to having no dependencies --> + + <!-- This module should kept to having no dependencies except nifi-versioned-components --> + <dependencies> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-versioned-components</artifactId> + <version>1.14.0-SNAPSHOT</version> + </dependency> + </dependencies> Review comment: Is there a specific reason for introducing `nifi-versioned-components` as a dependency to `nifi-api` in this pull request? There do not appear to be any other changes to `nifi-api` in this pull request, so it seems like this change is not necessary right now. In addition, this introduces the transitive dependency on `swagger-annotations`. ########## File path: nifi-versioned-components/pom.xml ########## @@ -0,0 +1,52 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi</artifactId> + <version>1.14.0-SNAPSHOT</version> + </parent> + + <artifactId>nifi-versioned-components</artifactId> + + <profiles> + <profile> + <id>nifi-versioned-components_jigsaw</id> + <activation> + <jdk>(1.8,)</jdk> + </activation> + <dependencies> + <dependency> + <groupId>javax.xml.bind</groupId> + <artifactId>jaxb-api</artifactId> + </dependency> + </dependencies> + </profile> + </profiles> + + <!-- This module should kept to having no dependencies --> Review comment: This comment is confusing in light of the dependency below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
