tpalfy commented on a change in pull request #5145: URL: https://github.com/apache/nifi/pull/5145#discussion_r650882924
########## File path: nifi-versioned-components/pom.xml ########## @@ -0,0 +1,52 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi</artifactId> + <version>1.14.0-SNAPSHOT</version> + </parent> + + <artifactId>nifi-versioned-components</artifactId> + + <profiles> + <profile> + <id>nifi-versioned-components_jigsaw</id> + <activation> + <jdk>(1.8,)</jdk> + </activation> + <dependencies> + <dependency> + <groupId>javax.xml.bind</groupId> + <artifactId>jaxb-api</artifactId> + </dependency> + </dependencies> + </profile> + </profiles> + + <!-- This module should kept to having no dependencies --> + <dependencies> + <dependency> + <groupId>io.swagger</groupId> + <artifactId>swagger-annotations</artifactId> + <version>1.5.16</version> + <scope>provided</scope> Review comment: ~~I'll remove the nifi-api -> nifi-versioned-components dependency then. When I open a new PR for Flow Analysis, I'll have nifi-framework-core depend on it instead. As suggested, later when an extension needs the VersionedComponent classes, it needs to introduce this dependency as well. It doesn't seem to be too hard to change later if we need it and now we can move forward.~~ I don't see it feasible to avoid the nifi-api -> nifi-versioned-components dependency. Sure it would make this PR easier to handle but that would just delay the problem to the immediate next PR: the one that introduces the Flow Analysis. As it needs to add a new interface to nifi-api that depends on the nifi-versioned-components classes. In fact this PR serves little to no purpose if the nifi-api -> nifi-versioned-components dependency is left out. It's just an oversized refactor then. Making the VersionedComponents available through the api is the _goal_ and the refactor is the _means_. Not the other way around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
