exceptionfactory commented on a change in pull request #5145:
URL: https://github.com/apache/nifi/pull/5145#discussion_r649606487
##########
File path: nifi-api/pom.xml
##########
@@ -22,5 +22,13 @@
</parent>
<artifactId>nifi-api</artifactId>
<packaging>jar</packaging>
- <!-- This module should kept to having no dependencies -->
+
+ <!-- This module should kept to having no dependencies except
nifi-versioned-components -->
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-versioned-components</artifactId>
+ <version>1.14.0-SNAPSHOT</version>
+ </dependency>
+ </dependencies>
Review comment:
Is there a specific reason for introducing `nifi-versioned-components`
as a dependency to `nifi-api` in this pull request? There do not appear to be
any other changes to `nifi-api` in this pull request, so it seems like this
change is not necessary right now. In addition, this introduces the transitive
dependency on `swagger-annotations`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
