szaszm commented on a change in pull request #1083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r649908587
##########
File path: libminifi/include/utils/GeneralUtils.h
##########
@@ -183,6 +185,18 @@ struct dereference_t {
constexpr detail::dereference_t dereference{};
+#if __cplusplus < 201703L
+template<typename T, typename Compare = std::less<T>>
+constexpr const T& clamp(const T& v, const T& lo, const T& hi, Compare less =
{}) {
+#if __cplusplus >= 201402L
+ gsl_Expects(!less(hi, lo));
+#endif
+ return less(v, lo) ? lo : (less(hi, v) ? hi : v);
+}
+#else
+using std::clamp;
+#endif /* < C++17 */
+
Review comment:
removed in e8f2c49
##########
File path:
extensions/standard-processors/tests/integration/SecureSocketGetTCPTest.cpp
##########
@@ -117,23 +117,16 @@ class SecureSocketTest : public IntegrationBase {
assert(0 == server_socket_->initialize());
isRunning_ = true;
- check = [this]() -> bool {
- return isRunning_;
- };
- handler = [](std::vector<uint8_t> *b, int *size) {
+ auto handler = [](std::vector<uint8_t> *b) {
std::cout << "oh write!" << std::endl;
Review comment:
removed in e8f2c49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
