fgerlits commented on a change in pull request #1083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r649765659
##########
File path:
extensions/standard-processors/tests/integration/SecureSocketGetTCPTest.cpp
##########
@@ -117,23 +117,16 @@ class SecureSocketTest : public IntegrationBase {
assert(0 == server_socket_->initialize());
isRunning_ = true;
- check = [this]() -> bool {
- return isRunning_;
- };
- handler = [](std::vector<uint8_t> *b, int *size) {
+ auto handler = [](std::vector<uint8_t> *b) {
std::cout << "oh write!" << std::endl;
Review comment:
This is an old debugging comment checked in by accident, but we might as
well remove it now.
```suggestion
```
##########
File path: libminifi/include/utils/GeneralUtils.h
##########
@@ -183,6 +185,18 @@ struct dereference_t {
constexpr detail::dereference_t dereference{};
+#if __cplusplus < 201703L
+template<typename T, typename Compare = std::less<T>>
+constexpr const T& clamp(const T& v, const T& lo, const T& hi, Compare less =
{}) {
+#if __cplusplus >= 201402L
+ gsl_Expects(!less(hi, lo));
+#endif
+ return less(v, lo) ? lo : (less(hi, v) ? hi : v);
+}
+#else
+using std::clamp;
+#endif /* < C++17 */
+
Review comment:
This is no longer used, so could be removed. But if you want to keep it
for future use, that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
