szaszm commented on a change in pull request #1128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1128#discussion_r666393263
##########
File path: libminifi/test/CPPLINT.cfg
##########
@@ -1,4 +1,4 @@
-filter=-build/namespaces
+filter=-build/namespaces,-whitespace/braces
Review comment:
There were two false positives in
PersistableKeyValueStoreServiceTest.cpp and
UnorderedMapKeyValueStoreServiceTest.cpp, "missing whitespace before {" at
Catch::clara::Opt construction. The google style guide allows uniform
initialization without a space before the brace.
##########
File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp
##########
@@ -317,7 +317,7 @@ class ConsumeKafkaPropertiesTest : public ConsumeKafkaTest {
return;
}
{
- SCOPED_INFO("ConsumeKafka timed out when waiting to receive the
message published to the kafka broker.");
+ INFO("ConsumeKafka timed out when waiting to receive the message
published to the kafka broker.");
Review comment:
`INFO` in Catch2 is practically the same as `SCOPED_INFO` in Catch 1.x
##########
File path: libminifi/test/unit/OptionalTest.cpp
##########
@@ -58,5 +58,5 @@ TEST_CASE("optional orElse", "[optional or else]") {
REQUIRE(7 == test2.value());
REQUIRE(3 == test3.value());
REQUIRE(!test4);
- REQUIRE_THROWS_AS(utils::optional<bool>{} | utils::orElse([]{ throw ex{};
}), const ex&);
+ REQUIRE_THROWS_AS(utils::optional<bool>{} | utils::orElse([]{ throw ex{};
}), ex);
Review comment:
Catch2 REQUIRE_THROWS_AS now adds `const&` to the type internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
