szaszm commented on a change in pull request #1128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1128#discussion_r666946070
##########
File path: extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp
##########
@@ -66,16 +66,9 @@ TEST_CASE("ConsumeWindowsEventLog constructor works",
"[create]") {
TestController test_controller;
std::shared_ptr<TestPlan> test_plan = test_controller.createPlan();
- REQUIRE_NOTHROW(ConsumeWindowsEventLog processor_one("one"));
-
- REQUIRE_NOTHROW(
- utils::Identifier uuid = utils::IdGenerator::getIdGenerator()->generate();
- ConsumeWindowsEventLog processor_two("two", uuid);
- ); // NOLINT
-
- REQUIRE_NOTHROW(
- auto processor = test_plan->addProcessor("ConsumeWindowsEventLog", "cwel");
- ); // NOLINT
+ REQUIRE_NOTHROW(ConsumeWindowsEventLog("one"));
+ REQUIRE_NOTHROW(ConsumeWindowsEventLog("two",
utils::IdGenerator::getIdGenerator()->generate())); // NOLINT
+ REQUIRE_NOTHROW(test_plan->addProcessor("ConsumeWindowsEventLog", "cwel"));
// NOLINT
Review comment:
Not sure why they were there. I can try removing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
