fgerlits commented on a change in pull request #1128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1128#discussion_r667004285
##########
File path: libminifi/test/keyvalue-tests/PersistableKeyValueStoreServiceTest.cpp
##########
@@ -33,17 +32,14 @@
static std::string config_yaml; // NOLINT
-static inline void configYamlHandler(Catch::ConfigData&, const std::string&
path) {
- config_yaml = path;
-}
-
int main(int argc, char* argv[]) {
Catch::Session session;
- auto& cli =
const_cast<Catch::Clara::CommandLine<Catch::ConfigData>&>(session.cli());
- cli["--config-yaml"]
- .describe("path to the config.yaml containing the
PersistableKeyValueStoreService controller service configuration")
- .bind(&configYamlHandler, "path");
+ auto cli = session.cli()
+ | Catch::clara::Opt{config_yaml, "config-yaml"}
Review comment:
I would put the `|` at the end of the line. It's OK at the beginning of
the next line, too, but then please do the same in
UnorderedMapKeyValueStoreServiceTest.cpp. Seeing it in two different ways
triggers my OCD. :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
