pvillard31 commented on a change in pull request #5229:
URL: https://github.com/apache/nifi/pull/5229#discussion_r672320236
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/ADLSCredentialsControllerService.java
##########
@@ -50,9 +50,8 @@
public static final PropertyDescriptor ACCOUNT_NAME = new
PropertyDescriptor.Builder()
.fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_NAME)
- .description(AzureStorageUtils.ACCOUNT_NAME_BASE_DESCRIPTION)
+ .description(AzureStorageUtils.ACCOUNT_NAME_BASE_DESCRIPTION +
AzureStorageUtils.ACCOUNT_NAME_SECURITY_DESCRIPTION)
.required(true)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
Review comment:
Are we sure this is enough to remove this line? I think the default is
`NONE` when not specified.
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/ADLSCredentialsControllerService.java
##########
@@ -50,9 +50,8 @@
public static final PropertyDescriptor ACCOUNT_NAME = new
PropertyDescriptor.Builder()
.fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_NAME)
- .description(AzureStorageUtils.ACCOUNT_NAME_BASE_DESCRIPTION)
+ .description(AzureStorageUtils.ACCOUNT_NAME_BASE_DESCRIPTION +
AzureStorageUtils.ACCOUNT_NAME_SECURITY_DESCRIPTION)
.required(true)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
Review comment:
Oh good point, thanks @adenes !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
