exceptionfactory commented on a change in pull request #5229:
URL: https://github.com/apache/nifi/pull/5229#discussion_r672378707
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/ADLSCredentialsControllerService.java
##########
@@ -65,16 +64,9 @@
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
- public static final PropertyDescriptor ACCOUNT_KEY = new
PropertyDescriptor.Builder()
- .fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_KEY)
- .description(AzureStorageUtils.ACCOUNT_KEY_BASE_DESCRIPTION)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
- .build();
+ public static final PropertyDescriptor ACCOUNT_KEY =
AzureStorageUtils.ACCOUNT_KEY;
Review comment:
Instead of keeping the local `ACCOUNT_KEY` property descriptor, it would
be better to replace existing references to use `AzureStorageUtils.ACCOUNT_KEY`
directly.
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/ADLSCredentialsControllerService.java
##########
@@ -65,16 +64,9 @@
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
- public static final PropertyDescriptor ACCOUNT_KEY = new
PropertyDescriptor.Builder()
- .fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_KEY)
- .description(AzureStorageUtils.ACCOUNT_KEY_BASE_DESCRIPTION)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
- .build();
+ public static final PropertyDescriptor ACCOUNT_KEY =
AzureStorageUtils.ACCOUNT_KEY;
- public static final PropertyDescriptor SAS_TOKEN = new
PropertyDescriptor.Builder()
- .fromPropertyDescriptor(AzureStorageUtils.PROP_SAS_TOKEN)
-
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
- .build();
+ public static final PropertyDescriptor SAS_TOKEN =
AzureStorageUtils.PROP_SAS_TOKEN;
Review comment:
Same as `ACCOUNT_KEY`, it would be better to replace references to
`SAS_TOKEN` with `AzureStorageUtils.PROP_SAS_TOKEN`.
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/ADLSCredentialsControllerService.java
##########
@@ -65,16 +64,9 @@
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
- public static final PropertyDescriptor ACCOUNT_KEY = new
PropertyDescriptor.Builder()
- .fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_KEY)
- .description(AzureStorageUtils.ACCOUNT_KEY_BASE_DESCRIPTION)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
- .build();
+ public static final PropertyDescriptor ACCOUNT_KEY =
AzureStorageUtils.ACCOUNT_KEY;
Review comment:
Thanks for following up. Although it is a public field, processor
variables are not part of the public API contract, just the property names
themselves. Since the change would still preserve the existing property name,
refactoring seems like the best approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
