adenes commented on a change in pull request #5229:
URL: https://github.com/apache/nifi/pull/5229#discussion_r672323268
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/ADLSCredentialsControllerService.java
##########
@@ -50,9 +50,8 @@
public static final PropertyDescriptor ACCOUNT_NAME = new
PropertyDescriptor.Builder()
.fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_NAME)
- .description(AzureStorageUtils.ACCOUNT_NAME_BASE_DESCRIPTION)
+ .description(AzureStorageUtils.ACCOUNT_NAME_BASE_DESCRIPTION +
AzureStorageUtils.ACCOUNT_NAME_SECURITY_DESCRIPTION)
.required(true)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
Review comment:
The builder is instantiated with
`fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_NAME)` so it inherits
`AzureStorageUtils.ACCOUNT_NAME`'s properties, including the expression
language scope.
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/ADLSCredentialsControllerService.java
##########
@@ -65,16 +64,9 @@
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
- public static final PropertyDescriptor ACCOUNT_KEY = new
PropertyDescriptor.Builder()
- .fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_KEY)
- .description(AzureStorageUtils.ACCOUNT_KEY_BASE_DESCRIPTION)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
- .build();
+ public static final PropertyDescriptor ACCOUNT_KEY =
AzureStorageUtils.ACCOUNT_KEY;
Review comment:
I was hesitant to remove this (actually first I removed then decided to
keep it this way) because this is a public field so theoretically this could
have been used by other (3rd party) processors so removing it would be a
breaking change.
But I don't have a strong opinion on this. Would you remove it,
@exceptionfactory ?
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/ADLSCredentialsControllerService.java
##########
@@ -65,16 +64,9 @@
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
- public static final PropertyDescriptor ACCOUNT_KEY = new
PropertyDescriptor.Builder()
- .fromPropertyDescriptor(AzureStorageUtils.ACCOUNT_KEY)
- .description(AzureStorageUtils.ACCOUNT_KEY_BASE_DESCRIPTION)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
- .build();
+ public static final PropertyDescriptor ACCOUNT_KEY =
AzureStorageUtils.ACCOUNT_KEY;
Review comment:
gotcha, updating the PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
