szaszm opened a new pull request #1142: URL: https://github.com/apache/nifi-minifi-cpp/pull/1142
squashed: commit baa3f502d8fdc6a395983295c8f4187c088765d5 Author: Marton Szasz <[email protected]> Date: Sun Jul 25 14:07:11 2021 +0200 patch sol2 to not fail in C++20 mode on mac xcode/AppleClang, due to const char*/const char8_t* incompatibility and the fact that u8"string" literals are now const char8*. error: invalid conversion from 'const char8_t*' to 'const char*' (and friends) commit 8d6476be877d14e64db25bbdc71adc30b5fc9dd6 Author: Marton Szasz <[email protected]> Date: Wed Jul 21 07:00:26 2021 +0200 back to C++20 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
