adamdebreceni commented on a change in pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142#discussion_r676561438
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>,
basic_string_view>,
#endif
Review comment:
I am OK with doing it in another PR, I am also OK with not making the
change if this is a rarely touched dependency (it seems to be), although I feel
that having a separate patch file helps with upgrades/tracking changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
