szaszm commented on a change in pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142#discussion_r676577714
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>,
basic_string_view>,
#endif
Review comment:
I agree that it would make the changes more visible, although I tried my
best by adding comments where I patched the source.
Changing this to ExternalProject would be less than ideal, because the
header would not be available before the first build.
Because of this I would go for FetchContent, but due to its different
syntax, I would most likely need to manually invoke the patch command at the
right times instead of letting cmake take care of it. This is somewhat unknown
territory and I would need to do more research, that's why I prefer not to do
it now.
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>,
basic_string_view>,
#endif
Review comment:
I agree that it would make the changes more visible, although I tried my
best by adding comments where I patched the source.
Changing this to ExternalProject would be less than ideal, because the
header would not be available before the first build.
Because of this, I would go for FetchContent, but due to its different
syntax, I would most likely need to manually invoke the patch command at the
right times instead of letting cmake take care of it. This is somewhat unknown
territory and I would need to do more research, that's why I prefer not to do
it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
