exceptionfactory commented on a change in pull request #5195:
URL: https://github.com/apache/nifi/pull/5195#discussion_r682084077
##########
File path: nifi-assembly/src/main/assembly/common.xml
##########
@@ -25,6 +25,8 @@
<useTransitiveFiltering>true</useTransitiveFiltering>
<includes>
<include>nifi-bootstrap-utils</include>
+ <include>nifi-properties</include>
+ <include>nifi-property-utils</include>
Review comment:
The `DiagnosticContext` class references `BootstrapProperties` and
`NiFiBootstrapUtils` for loading properties, which come from these
dependencies. The current class design is problematic in that incorporates both
property loading and business logic. The implementation could also be
refactored to avoid these dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
