exceptionfactory commented on a change in pull request #5195:
URL: https://github.com/apache/nifi/pull/5195#discussion_r682574278
##########
File path: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
##########
@@ -281,6 +285,23 @@ public static void main(String[] args) throws IOException,
InterruptedException
}
}
+ private void runDiagnostics() throws IOException {
+ final DiagnosticContext diagnosticContext = new DiagnosticContext();
Review comment:
The `RunNiFi` class has a `bootstrapConfigFile` property referencing
`bootstrap.conf`. The `DiagnosticContext` should be refactored to use the
existing file reference and similar approach to loading properties as other
methods in this class. Refactoring also provides an opportunity to separate
configuration properties from evaluation methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
