szaszm commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r693909181
########## File path: libminifi/src/core/extension/ExtensionManager.cpp ########## @@ -0,0 +1,134 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "core/extension/ExtensionManager.h" +#include "core/logging/LoggerConfiguration.h" +#include "utils/file/FileUtils.h" +#include "core/extension/Executable.h" +#include "utils/file/FileMatcher.h" +#include "core/extension/DynamicLibrary.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace core { +namespace extension { + +namespace { +struct LibraryDescriptor { + std::string name; + std::string dir; + std::string filename; + + bool verify(const std::shared_ptr<logging::Logger>& /*logger*/) const { + // TODO(adebreceni): check signature + return true; + } Review comment: The only was to signal an error from constructors is through exceptions, so it's hard to avoid them there. But in general I think exceptions are a great way to signal error. Enforcing verification criteria in the constructor would allow to have the result of future verification be a class invariant, thus reducing the class state. Reducing state means simpler code and less opportunity to forget handling a special case. My exception usage preferences are quite the opposite of yours: [Using exceptions for errors only](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#e3-use-exceptions-for-error-handling-only), [including establishing invariants](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#e5-let-a-constructor-establish-an-invariant-and-throw-if-it-cannot), but not part of the happy path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
