adamdebreceni commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r694560917
########## File path: libminifi/include/utils/file/FileMatcher.h ########## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <string> +#include <vector> +#include <set> +#include <utility> +#include <memory> + +#include "utils/OptionalUtils.h" +#include "core/logging/Logger.h" + +struct FileMatcherTestAccessor; + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace utils { +namespace file { + +class FileMatcher { Review comment: as the logic inside `FileMatcher` is pretty "involved", moving all of them into a single function would certainly cause more confusion, also we could think of `FileMatcher` as the equivalent of `std::regex`, as the pattern itself can contain errors (and `FileMatcher` logs them), this "error-state" is better represented construction time than usage time (here we could throw from the constructor, unclear if that is something we would like to do and stop loading the extension, currently it is on a "best-effort" basis) should we load extensions even if we encounter an invalid pattern (and log errors) or should we refuse to load extension then? (the only problem with the latter is that then we won't load any extensions, not even the curl extension by which the c2-server could correct the pattern) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
