szaszm commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r693920970
########## File path: libminifi/src/core/extension/ExtensionManager.cpp ########## @@ -0,0 +1,134 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "core/extension/ExtensionManager.h" +#include "core/logging/LoggerConfiguration.h" +#include "utils/file/FileUtils.h" +#include "core/extension/Executable.h" +#include "utils/file/FileMatcher.h" +#include "core/extension/DynamicLibrary.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace core { +namespace extension { + +namespace { +struct LibraryDescriptor { + std::string name; + std::string dir; + std::string filename; + + bool verify(const std::shared_ptr<logging::Logger>& /*logger*/) const { + // TODO(adebreceni): check signature + return true; + } Review comment: I would be fine with a requirement that extension changes on disk must happen while the extensions are not loaded in minifi. They only need to change during minifi updates and possibly through C2 or registry fetches in the future. I consider them internals, so if someone randomly changes them, they are shooting themselves in the foot anyway. Just like you don't overwrite system dlls on windows while it's running. Undefined behavior. Treating them like this would make them conceptually "const" and fine to base invariants on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
