lordgamez commented on a change in pull request #1158: URL: https://github.com/apache/nifi-minifi-cpp/pull/1158#discussion_r710052404
########## File path: extensions/azure/storage/AzureDataLakeStorageClient.cpp ########## @@ -0,0 +1,55 @@ +/** + * @file AzureDataLakeStorageClient.cpp + * AzureDataLakeStorageClient class implementation + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "AzureDataLakeStorageClient.h" + +namespace org::apache::nifi::minifi::azure::storage { + +void AzureDataLakeStorageClient::resetClientIfNeeded(const std::string& connection_string, const std::string& file_system_name) { Review comment: Do you think we should implement a mechanism to process the requests in parallel until a client reset is needed (then wait for the ongoing parallel requests to finish and reset the client continuing to process the queued requests) or sequential processing with a lock is sufficient? Or maybe we can improve it later in a separate PR, but we can add a lock for the onTrigger now as there seems to be already a corresponding Jira ticket according to @arpadboda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
