lordgamez commented on a change in pull request #1158:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1158#discussion_r710203334
##########
File path: extensions/azure/processors/PutAzureBlobStorage.cpp
##########
@@ -90,14 +81,13 @@ const core::Relationship
PutAzureBlobStorage::Failure("failure", "Unsuccessful o
void PutAzureBlobStorage::initialize() {
// Set the supported properties
- setSupportedProperties({
+ updateSupportedProperties({
Review comment:
After considering it I think keeping all the properties including the
inherited ones in the processor's single `setSupportedProperties` call would be
the best option to go with. It's more clear what properties are available for
that specific processor and also it's easy to miss calling the base class's
`initialize` and try to debug why the tests fail in case we include them there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
