Lehel44 commented on a change in pull request #5356:
URL: https://github.com/apache/nifi/pull/5356#discussion_r713281467
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-headless-server/src/main/java/org/apache/nifi/headless/HeadlessNiFiServer.java
##########
@@ -137,7 +141,8 @@ public void preDestruction() throws
AuthorizerDestructionException {
bulletinRepository,
variableRegistry,
flowRegistryClient,
- extensionManager);
+ extensionManager,
+ statusHistoryRepository);
Review comment:
I believe we should first determine if we require this functionality on
the https://nifi.apache.org/minifi/ server as well. The StandardMiNiFiServer's
ancestor is the HeadlessNiFiServer. What are your thoughts on just returning
null or throwing an UnsupportedOperationException?
I realize that constructing a VolatileComponentStatusRepository will not do,
but this capability might not be required here. The DecomissionTask, for
example, was added to the NiFi server interface earlier this year, and the
headless implementation simply returns null. The spring application context is
not utilized at all in the class, and no injection is used for object creation,
which might be for a cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
