Lehel44 commented on a change in pull request #5356:
URL: https://github.com/apache/nifi/pull/5356#discussion_r712540740
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-headless-server/src/main/java/org/apache/nifi/headless/HeadlessNiFiServer.java
##########
@@ -137,7 +141,8 @@ public void preDestruction() throws
AuthorizerDestructionException {
bulletinRepository,
variableRegistry,
flowRegistryClient,
- extensionManager);
+ extensionManager,
+ statusHistoryRepository);
Review comment:
By the way, I completely disagree with the direction of development on
this. The regression induced by modifications shall not go unseen and should be
covered by unit tests. If a modification causes undesirable changes or
problems, we should fix it and extend the unit test coverage for the issue so
that it does not prevent us from making essential changes in the future.
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-headless-server/src/main/java/org/apache/nifi/headless/HeadlessNiFiServer.java
##########
@@ -137,7 +141,8 @@ public void preDestruction() throws
AuthorizerDestructionException {
bulletinRepository,
variableRegistry,
flowRegistryClient,
- extensionManager);
+ extensionManager,
+ statusHistoryRepository);
Review comment:
I can think of two solutions now. And any better ideas are appreciated.
1. A default interface method would do it.
2. I can try to move the
StatusHistoryDumpFactory::getStatusHistoryDumpFactory to a separate interface
which only the JettyServer would implement. In the BootstrapListener with an
instanceOf check and casting, the method would be accessible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
