exceptionfactory commented on a change in pull request #5475:
URL: https://github.com/apache/nifi/pull/5475#discussion_r736686088
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -1269,4 +1291,17 @@ private Charset getCharsetFromMediaType(MediaType
contentType) {
private static File getETagCacheDir() throws IOException {
return
Files.createTempDirectory(InvokeHTTP.class.getSimpleName()).toFile();
}
+
+ private String getFileNameFromUrl(URL url) {
+ String fileName;
+ String path = StringUtils.removeEnd(url.getPath(), "/");
+
+ if (StringUtils.isEmpty(path)) {
+ fileName = url.getHost();
Review comment:
Thanks for the reply, I will defer to @markap14. Since using the URL
path for the filename is not a default setting, the flow designer should be
aware of the potential implications. If the current implementation remains
as-is, recommend updating the property description to indicate that the
filename will fall back to the URL host when the URL does not contain a path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
