nandorsoma commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-952019241
> > Thanks for the contribution! > > What if the file name as url encoded characters in it? Shouldn't those be unencoded? My thinking is that the file names should be the same as if you used GetFile to get it. > > Hey @ottobackwards! Thank you for your review! URL encoding is a good point, I'll try to find something to handle them. I've tried to answer your other remarks, please see them above. I was thinking about unending the URL. For most characters it wouldn't be a problem, but what happens when you encode a "/" as %2F? In this case the filename would contain a "/" which is not valid in files and would also mean that you could construct a path in the filename. Since other processors expect a filename in that property, not a path, I think this wouldn't be backwards compatible. Having encoded characters in the filename is not nice, but at least they are valid. All in all, I'd leave filename as it is. If you agree, I can add a note to the documentation, that the filename could contain url encoded characters and I can also extend the test with a case which ensures that encoded characters in the url remain encoded in the filename too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
