exceptionfactory commented on a change in pull request #5475:
URL: https://github.com/apache/nifi/pull/5475#discussion_r736645088
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -1269,4 +1291,17 @@ private Charset getCharsetFromMediaType(MediaType
contentType) {
private static File getETagCacheDir() throws IOException {
return
Files.createTempDirectory(InvokeHTTP.class.getSimpleName()).toFile();
}
+
+ private String getFileNameFromUrl(URL url) {
+ String fileName;
+ String path = StringUtils.removeEnd(url.getPath(), "/");
+
+ if (StringUtils.isEmpty(path)) {
+ fileName = url.getHost();
Review comment:
Instead of using the URL host, what do you think about changing this to
`null` and falling back to the current behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
