szaszm opened a new pull request #1207: URL: https://github.com/apache/nifi-minifi-cpp/pull/1207
Azure-sdk dependencies were not respected, because of a mismatch between cmake target names (-external vs -external-build). After fixing this issue, the build failed, because the azure-sdk cmake scripts tried to install stuff to /usr/local, which they thankfully couldn't. Apparently the azure sdk third party was used directly from its source/build directory, so it had no install dir and defaulted to /usr/local. I adapted it to look like other third parties, with an install directory under our build/thirdparty dir, where the package can install and we can consume its artifacts. https://issues.apache.org/jira/browse/MINIFICPP-1674 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
