szaszm commented on a change in pull request #1207:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1207#discussion_r738782522
##########
File path: cmake/BundledAzureSdkCpp.cmake
##########
@@ -56,6 +63,7 @@ function(use_bundled_libazure SOURCE_DIR BINARY_DIR)
URL_HASH
"SHA256=d4e80ea5e786dc689ddd04825d97ab91f5e1ef2787fa88a3d5ee00f0b820433f"
BUILD_IN_SOURCE true
Review comment:
I think this is a MAX_PATH issue. The build failed for me too locally,
but when I moved the repo to a short path (`C:\a\m`), it worked fine. Probably
related to removing BUILD_IN_SOURCE. A few ideas:
- rename the cmake target to something shorter, like "asdkext" to save a few
characters on the ExternalProject build dir names
- move the build directory outside GITHUB_WORKSPACE (==
`D:\a\nifi-minifi-cpp\nifi-minifi-cpp`). I don't want to go more than one level
up.
- revert to BUILD_IN_SOURCE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
