lordgamez commented on a change in pull request #1207:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1207#discussion_r737663971



##########
File path: cmake/BundledAzureSdkCpp.cmake
##########
@@ -56,6 +63,7 @@ function(use_bundled_libazure SOURCE_DIR BINARY_DIR)
             URL_HASH 
"SHA256=d4e80ea5e786dc689ddd04825d97ab91f5e1ef2787fa88a3d5ee00f0b820433f"
             BUILD_IN_SOURCE true

Review comment:
       I only remember that the first time Azure was introduced the install 
step wasn't working for our use case for some reason and that's why only the 
build step was executed and we depended on *-build target as a workaround. 
Since then it has changed as we updated it a few times so it may have been 
fixed so these parts can be removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to